Move freeform block to separate package #70603
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -2.93 kB (-0.16%) Total Size: 1.86 MB
ℹ️ View Unchanged
|
ellatrix
commented
Jul 3, 2025
Member
Author
There was a problem hiding this comment.
The native block is using MissingEdit... so I copied it here.
tyxla
reviewed
Jul 4, 2025
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
This is great work @ellatrix and I've tried it out with the TinyMCE removal experiment, and it still seems to work OK!
This could also be a good step towards finally deprecating and moving TinyMCE to another plugin at some point. Maybe time to revive the experiment also and see how far we can go with it.
I see some tests are failing, but besides that, what else do you think this needs before being ready for a review?
| textColumns, | ||
| verse, | ||
| video, | ||
| classic, |
Member
There was a problem hiding this comment.
Won't this remove the block completely for mobile?
Member
Author
There was a problem hiding this comment.
I think it's still registered through registerCoreBlocks, but not 100% sure. I've asked the mobile team to test and review the mobile part.
Member
Author
There was a problem hiding this comment.
For mobile I'm pretty much blind and am completely relying on the unit and e2e tests
Member
There was a problem hiding this comment.
Yes, the changes to this file result in no longer registering the block type, which means the new packages/block-freeform/src/missing.native.js is never utilized.
I opened #70644 with suggestions to address this.
Member
There was a problem hiding this comment.
Took a look at #70644 - let's land it before getting back to this one.
Member
Author
|
@tyxla It's ready for review. What are all the scenarios we need to test?
Fixed it |
ellatrix
commented
Jul 4, 2025
| 'wp-block-library', | ||
| 'wp-blocks', | ||
| 'wp-edit-site', | ||
| 'wp-edit-post', |
Member
Author
There was a problem hiding this comment.
@Mamaduka I just added wp-block-freeform-editor to edit-post, is this normal?
Member
There was a problem hiding this comment.
It looks like a new script has wp-polyfill as a dependency. I've a feeling it's one of the low-level packages that requires it and then ends up as a dependency for other packages.
This doesn't need to be a blocker here.
ellatrix
requested review from
adamziel,
ajitbohra,
draganescu,
fabiankaegy,
juanmaguitar,
kevin940726,
ndiego and
spacedmonkey
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ellatrix
commented
Jul 4, 2025
Member
Author
There was a problem hiding this comment.
I wonder if block-freeform is the right pattern. That would suggest block-library and block-editor are a library and editor block... So maybe not. Maybe block-type-freeform?
Member
There was a problem hiding this comment.
I think you have a point. Also, what about freeform-block?
Member
Author
There was a problem hiding this comment.
I don't like this because when we do this for other blocks, they'll not fit the alphabetical order
|
Flaky tests detected in 247e819. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/16076572142
|
Member
I'll try to take a look in the next couple of days and write some detailed testing instructions. |
dcalhoun
reviewed
Jul 8, 2025
Member
dcalhoun
left a comment
dcalhoun
left a comment
There was a problem hiding this comment.
Thanks for sharing this PR.
I tested mobile and we should make some changes to avoid title-less fallback UI in the mobile editor. The issue can be seen in the recording below. I opened #70644 suggesting changes to resolve this issue.
Mobile editor title-less fallback recording
classic-block-after.mp4
| @@ -3,4 +3,4 @@ | |||
| */ | |||
| import { init } from './'; | |||
|
|
|||
| export default init(); | |||
Member
There was a problem hiding this comment.
Why was the invocation removed? Is there value in this file without it?
It appears other init files in packages/block-library also included an invocation. Is that an oversight?
Member
Author
There was a problem hiding this comment.
Not an oversight, it's not the same init function
Member
There was a problem hiding this comment.
Understood, regarding the absence of an oversight.
If you have time and are willing to elaborate, I welcome answers to my other questions to help me better understand:
Why was the invocation removed? Is there value in this file without it?
I'll rephrase my questions for clarity: is there a context where packages/block-freeform/src/init.js is used? If so, how is it used?
Thank you. 🙇🏻♂️
| textColumns, | ||
| verse, | ||
| video, | ||
| classic, |
Member
There was a problem hiding this comment.
Yes, the changes to this file result in no longer registering the block type, which means the new packages/block-freeform/src/missing.native.js is never utilized.
I opened #70644 with suggestions to address this.
Member
In the meantime, I'd test with these combinations:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Moves the freeform block from the block library package to its own package.
Why?
How?
We extract the code to a new package. All
edit-packages that need it should be updated.We can make a back port PR after packages sync to core. Then adjust:
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast