DataViews: Avoid unselecting items that are not rendered#70572
Closed
youknowriad wants to merge 1 commit intotrunkfrom
Closed
DataViews: Avoid unselecting items that are not rendered#70572youknowriad wants to merge 1 commit intotrunkfrom
youknowriad wants to merge 1 commit intotrunkfrom
Conversation
youknowriad
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -66 B (0%) Total Size: 1.87 MB
ℹ️ View Unchanged
|
Member
|
I can confirm that this fixes deselection when searching the items. I also noticed that it introduces a regression when the selected item is moved to the trash. Previously, it would load the homepage after the deletion; now it will display a warning in the canvas. Not sure if this is intentional now. ScreencastCleanShot.2025-07-03.at.18.20.18.mp4 |
Contributor
Author
|
Not sure how relevant is this still. We can resurface it if it comes up again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
In the pages dataviews, when you select an item and then search for something unrelated, the preview changes back to the front page. For me is this the wrong behavior and the previous selection should be kept unless the user changes it explicitly.
Testing Instructions