Skip to content

Conversation

@SainathPoojary
Copy link
Contributor

@SainathPoojary SainathPoojary commented Jun 6, 2025

What?

Related to: #44401

Replaces the deprecated position prop with the recommended placement prop in the Warning component’s Popover

Why?

The position prop in Popover is deprecated. This update ensures the component uses the latest API.

Testing Instructions

  1. Run npm run storybook:dev.
  2. Navigate to block-editor/components/warning story.
  3. Interact with the “More options” (three dots) menu in the Warning.
  4. Ensure the dropdown appears in the correct position relative to the button.

Screenshots or screencast

Before:

after.mov

After:

before.mov

@SainathPoojary SainathPoojary requested a review from ellatrix as a code owner June 6, 2025 09:01
@github-actions
Copy link

github-actions bot commented Jun 6, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: SainathPoojary <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added [Type] Code Quality Issues or PRs that relate to code quality [Package] Block editor /packages/block-editor labels Jun 9, 2025
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @SainathPoojary!

@Mamaduka Mamaduka added the props-bot Manually triggers Props Bot to ensure the list of props is up to date. label Jun 10, 2025
@github-actions github-actions bot removed the props-bot Manually triggers Props Bot to ensure the list of props is up to date. label Jun 10, 2025
@Mamaduka Mamaduka merged commit 366670e into WordPress:trunk Jun 10, 2025
70 of 71 checks passed
@github-actions github-actions bot added this to the Gutenberg 21.1 milestone Jun 10, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Block editor /packages/block-editor [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants