Skip to content

Fix: Site logo & image block takes huge space if we try to rotate it … #70312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
OpuRockey wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Fix: Site logo & image block takes huge space if we try to rotate it … #70312

OpuRockey wants to merge 1 commit into from

Conversation

@OpuRockey
Copy link
Contributor

@OpuRockey OpuRockey commented Jun 4, 2025 •
edited
Loading

What?

Closes #70311

Why?

This PR will fix following issues:

  1. After adding an image to site logo OR image block, if we try to rotate it, it takes very long spaces on top & bottom.
  2. Fixed deprecated use of useResizeObserver API.

Testing Instructions

  1. Select the site logo block
  2. Add an image.
  3. Click on Crop button from block control setting.
  4. Click on the Rotate option.
  5. Image will take now appropriate space.

Screenshots or screencast

Before After
image image

@OpuRockey OpuRockey requested a review from ellatrix as a code owner June 4, 2025 13:20
@github-actions
Copy link

github-actions bot commented Jun 4, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: OpuRockey <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Package] Block editor /packages/block-editor labels Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ellatrix ellatrix Awaiting requested review from ellatrix ellatrix is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

[Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Site logo & image block takes huge space if we try to rotate it from the editor

2 participants

@OpuRockey @t-hamano