Ensure the actual tests environment is used for e2e tests #70280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
added
the
[Type] Automated Testing
westonruter
requested review from
ObliviousHarmony,
ajitbohra,
gziolo,
nerrad,
ntwb,
ryanwelcher and
t-hamano
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.85 MB ℹ️ View Unchanged
|
swissspidy
approved these changes
Jun 14, 2025
6 tasks
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…70280) Co-authored-by: westonruter <[email protected]> Co-authored-by: swissspidy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the
testsenvironment inwp-envuses the port8889. On my system, I am overriding this via.wp-env.override.jsonuse a different port number for thedevelopmentandtestsenvironments:{ "$schema": "./schemas/json/wp-env.json", "core": "../../../", "port": 8891, "testsPort": 8991, "env": { "development": { "phpmyadminPort": 9001 }, "tests": { "mappings": { "/wordpress-phpunit": "../../../../tests/phpunit" } } } }This is important to override because the
WordPress/wordpress-developrepo also uses the8889port for its development environment. In this way the Gutenberg environment can run at the same time as the wordpress-develop environment.Nevertheless, even though I overrode the
testsport to be8991, I found that when I rannpm run test:e2eit would run the tests still onhttp://localhost:8889. The result is that it clobbered the database of my wordpress-develop environment, leaving me with zero published posts and Twenty Twenty-One theme active. The command fails as well with an error:This is expected given that the wordpress-develop environment is not the same as the Gutenberg test environment which has that plugin installed.
If I tried modifying the
.envfile in wordpress-develop to use a different port number, like 18889, thennpm run test:e2efails with:Also, this is expected because it is (erroneously) looking to use the test server at port
8889, when according to my.wp-env.override.jsonit should be using port8991.So this PR fixes the issue by loading up the current
WPConfigin order to obtain theenvConfig.env.tests.port. This is then passed to Playwright via theWP_BASE_URLenvironment variable if one is not already set.