Button: Avoid focus loss when unlinking using keyboard#70192
Merged
Conversation
Mamaduka
added
[Type] Bug
|
Size Change: -5 B (0%) Total Size: 1.85 MB
ℹ️ View Unchanged
|
Mamaduka
force-pushed
the
fix/button-link-control-focus-loss
branch
from
35c954c to
9c72767
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 9c72767. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/15224026757
|
t-hamano
approved these changes
May 25, 2025
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
LGTM! The screenreader reads out correctly without losing focus when unlinking:
2bd58a91a074cd76fb68eb62e92fbc0a.mp4
Member
Author
|
Thanks for testing, @t-hamano! |
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: t-hamano <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
PR fixes the loss when unlinking the button block using the keyboard. Previously, a different
ToolbarButtoncomponent was mounted based on theisURLSetstate. Reusing the sameToolbarButtonand toggling props avoids this problem.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2025-05-23.at.15.41.33.mp4