FontSizePicker: Show min-max range for fluid font sizes in dropdown. #69956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
added
[Type] Enhancement
Member
|
We could have done with design feedback on the issue before jumping to PR so let's do that first then consider this PR after. For now please don't merge this until a direction is decided. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #69939
This PR updates the
FontSizePickerSelectcomponent to improve how fluid font size presets are displayed in the dropdown. Instead of using thesizeproperty as the hint, it now shows values from thefluidproperty (minandmax) when they are available.Why?
Currently, the
FontSizePickerSelectcomponent uses thesizeproperty as the hint, even when thefluidproperty is present. However, thesizemay not accurately represent the rendered font size for fluid presets, as it is derived from the min–max fluid range.This change helps reduce confusion by explicitly displaying the fluid font size range in the UI.
How?
Updated the FontSizePickerSelect component to:
Fluid (min – max)when both are definedFluid (≥ min)when only min is definedFluid (≤ max)when only max is definedTesting Instructions
fluidproperty when its present.Note: Update
theme.jsonto have atleast 6 sizes to enable the dropdown selector instead of toggle.Testing Instructions for Keyboard
Same
Screenshots or screencast