Navigation Link, Navigation Submenu: Remove the title attribute controls by Infinite-Null · Pull Request #69689 · WordPress/gutenberg

Infinite-Null · 2025-03-25T06:29:04Z

What?

Removes the Title attribute UI option from Navigation Submenu block and Custom Link button to align with accessibility best practices.

Testing Instructions

Open a post or page.
Insert an Image block.
Go to the Inspector control under the advanced section, and see if the title input is there.
Insert the Navigation block and add a submenu and a page link
For both blocks, check if the title input is there.

Screenshots or screencast

Before	After

github-actions · 2025-03-27T06:26:33Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Infinite-Null <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: joedolson <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Infinite-Null · 2025-03-28T07:24:03Z

The failing tests don’t seem to be related to the changes in this PR.

t-hamano

Thanks for the PR!

I think it would be good to focus only on two blocks, core/navigation-link and core/navigation-submenu in this PR.

If we plan to remove the title attribute from the Image block, we need to address the following tasks:

If we update the save function, we will need to add a block deprecation.
The title attribute is allowed to be used as Block Binding API (See this core code). This means that we may need to prepare a patch that removes the title attribute from the supported attributes to the core along with this PR.

I think It's too big to tackle all the tasks in one PR.

Infinite-Null · 2025-03-31T06:02:30Z

Hi @t-hamano,
I have updated the PR to remove title input from core/navigation-submenu and core/navigation-link. Could you please review this at your convenience.
Thank You!

t-hamano

I think we need to completely remove code related to the title attribute. For example:

gutenberg/packages/block-library/src/navigation-link/index.php

Lines 252 to 254 in d8545b2

    
           if ( isset( $attributes['title'] ) ) { 
        
           	$html .= ' title="' . esc_attr( $attributes['title'] ) . '"'; 
        
           }

gutenberg/packages/block-library/src/navigation-link/transforms.js

Line 124 in d8545b2

title,

It's a good idea to go through the code in both blocks and look for anything that needs to be removed.

Infinite-Null · 2025-04-01T06:23:17Z

Hi @t-hamano,
I have updated the PR and removed the title attribute from other places as well. Could you please review it at your convenience and let me know if I’ve missed anything?

Thank You!

t-hamano

LGTM! I think all code related to the title attribute has been removed.

Since I think this change is very important for site builders, I'm adding a Needs dev note label to announce it in the next major release.

…ping attribute support (#70234) * Revert the changes from PR #69689 * Remove title attribute from Controls in Navigation Link and Submenu blocks Co-authored-by: Infinite-Null <[email protected]> Co-authored-by: t-hamano <[email protected]>

…ols (WordPress#69689) * Remove Title attribute controls * Remove Title controls from Image component * Remove 'title' attribute from navigation link and submenu blocks * Remove title attribute checks from custom sources tests * Revert image changes * Remove `title` attribute from navigation link and submenu blocks Co-authored-by: Infinite-Null <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: carolinan <[email protected]> Co-authored-by: joedolson <[email protected]>

…ping attribute support (WordPress#70234) * Revert the changes from PR WordPress#69689 * Remove title attribute from Controls in Navigation Link and Submenu blocks Co-authored-by: Infinite-Null <[email protected]> Co-authored-by: t-hamano <[email protected]>

priethor · 2025-10-29T20:20:10Z

@t-hamano do you think it makes sense to combine this PR's dev note with the other deprecations?

t-hamano · 2025-10-30T00:43:42Z

@priethor As a follow-up to this PR, I recalled that the title attribute was restored internally in #70234. This means that only the title UI control was removed, so it doesn't affect backward compatibility. Therefore, I think a Dev Note is unnecessary.

Remove Title attribute controls

d29c6ed

Mamaduka changed the title ~~Remove Title attribute controls~~ Navigation Link/Submenu: Remove the title attribute controls Mar 25, 2025

Infinite-Null added 3 commits March 26, 2025 11:31

Remove Title controls from Image component

b77892e

Remove 'title' attribute from navigation link and submenu blocks

811b489

Remove title attribute checks from custom sources tests

7f6c98e

Infinite-Null marked this pull request as ready for review March 27, 2025 06:26

Infinite-Null requested review from ajitbohra, artemiomorales, fabiankaegy, juanmaguitar and ndiego as code owners March 27, 2025 06:26

Infinite-Null changed the title ~~Navigation Link/Submenu: Remove the title attribute controls~~ Remove the title attribute controls Mar 27, 2025

Merge branch 'trunk' into remove/title-attribute

81a1a85

t-hamano reviewed Mar 28, 2025

View reviewed changes

Revert image changes

632d05d

Infinite-Null requested a review from t-hamano March 31, 2025 06:02

t-hamano changed the title ~~Remove the title attribute controls~~ Navigation Link, Navigation Submenu: Remove the title attribute controls Mar 31, 2025

t-hamano reviewed Mar 31, 2025

View reviewed changes

Remove title attribute from navigation link and submenu blocks

3f66eee

Infinite-Null requested a review from t-hamano April 1, 2025 06:23

t-hamano approved these changes Apr 2, 2025

View reviewed changes

t-hamano added the Needs Dev Note Requires a developer note for a major WordPress release cycle label Apr 2, 2025

t-hamano merged commit 6985f08 into WordPress:trunk Apr 2, 2025

github-actions Bot added this to the Gutenberg 20.7 milestone Apr 2, 2025

t-hamano mentioned this pull request May 14, 2025

Navigation Submenu, Custom Link Block: Consider removing the title editing UI #69663

Closed

Infinite-Null added a commit to Infinite-Null/gutenberg that referenced this pull request May 28, 2025

Revert the changes from PR WordPress#69689

2d98e9e

Mamaduka mentioned this pull request May 29, 2025

Navigation Link, Navigation Submenu: Hide title UI controls while keeping attribute support #70234

Merged

priethor mentioned this pull request Oct 16, 2025

6.9 Dev Note Tracking Issue #72386

Closed

24 tasks

t-hamano removed the Needs Dev Note Requires a developer note for a major WordPress release cycle label Oct 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Navigation Link, Navigation Submenu: Remove the title attribute controls#69689

Navigation Link, Navigation Submenu: Remove the title attribute controls#69689
t-hamano merged 7 commits into
WordPress:trunkfrom
Infinite-Null:remove/title-attribute

Infinite-Null commented Mar 25, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Mar 27, 2025 •

edited

Loading

Uh oh!

Infinite-Null commented Mar 28, 2025

Uh oh!

t-hamano left a comment

Uh oh!

Infinite-Null commented Mar 31, 2025

Uh oh!

t-hamano left a comment

Uh oh!

Infinite-Null commented Apr 1, 2025

Uh oh!

t-hamano left a comment

Uh oh!

priethor commented Oct 29, 2025

Uh oh!

t-hamano commented Oct 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	if ( isset( $attributes['title'] ) ) {
	$html .= ' title="' . esc_attr( $attributes['title'] ) . '"';
	}

Conversation

Infinite-Null commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What?

Testing Instructions

Screenshots or screencast

Uh oh!

github-actions Bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Infinite-Null commented Mar 28, 2025

Uh oh!

t-hamano left a comment

Choose a reason for hiding this comment

Uh oh!

Infinite-Null commented Mar 31, 2025

Uh oh!

t-hamano left a comment

Choose a reason for hiding this comment

Uh oh!

Infinite-Null commented Apr 1, 2025

Uh oh!

t-hamano left a comment

Choose a reason for hiding this comment

Uh oh!

priethor commented Oct 29, 2025

Uh oh!

t-hamano commented Oct 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Infinite-Null commented Mar 25, 2025 •

edited

Loading

github-actions Bot commented Mar 27, 2025 •

edited

Loading