Stylelint-config: Add stylelint-scss as a peer dependency #69685
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
added
[Type] Code Quality
| "peerDependencies": { | ||
| "stylelint": "^16.8.2" | ||
| "stylelint": "^16.8.2", | ||
| "stylelint-scss": "^6.4.0" |
There was a problem hiding this comment.
Hey @Mamaduka,
I chose ^6.4.0 for stylelint-scss based on the version already used in the package-lock.json, where it’s pulled in as a dependency of stylelint-config-recommended-scss.
It was using "stylelint-scss": "^6.4.0" as it's dependency
"packages/stylelint-config/node_modules/stylelint-config-recommended-scss": {
"version": "14.1.0",
"resolved": "https://registry.npmjs.org/stylelint-config-recommended-scss/-/stylelint-config-recommended-scss-14.1.0.tgz",
"integrity": "sha512-bhaMhh1u5dQqSsf6ri2GVWWQW5iUjBYgcHkh7SgDDn92ijoItC/cfO/W+fpXshgTQWhwFkP1rVcewcv4jaftRg==",
"dependencies": {
"postcss-scss": "^4.0.9",
"stylelint-config-recommended": "^14.0.1",
"stylelint-scss": "^6.4.0"
},
"engines": {
"node": ">=18.12.0"
},
"peerDependencies": {
"postcss": "^8.3.3",
"stylelint": "^16.6.1"
},
"peerDependenciesMeta": {
"postcss": {
"optional": true
}
}
},
Mamaduka
added
the
props-bot
github-actions
bot
removed
the
props-bot
…69685) * Stylelint-config: Add stylelint-scss as a peer dependency * Stylelint-config: Update package-lock.json Co-authored-by: SainathPoojary <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: anomiex <[email protected]>
3 participants
What?
Closes #69684
PR adds missing dependencies for the @wordpress/stylelint-scss package.
Testing Instructions
Verify that the change makes sense.