Fix: Expose TypeScript types for subcomponents #69619
Conversation
Mamaduka
added
[Type] Developer Documentation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Refactoring all compound components to use the |
mirka
left a comment
mirka
left a comment
There was a problem hiding this comment.
Looking good!
We also want to list Popover.Slot in the Storybook subcomponents. For the props table to work, this will require a named export for the PopoverSlot function before Object.assigning it. So something like:
export const PopoverSlot = forwardRef(
( { name = SLOT_NAME }: { name?: string }, ref: ForwardedRef< any > ) => {
return (
<Slot
bubblesVirtually
name={ name }
className="popover-slot"
ref={ ref }
/>
);
}
);
|
Thanks for the review @mirka! I have added the |
|
@Rishit30G you can take inspiration from existing compound components such as |
|
Thanks @ciampo! 🙇🏻 I have updated the PR accordingly, sharing a screenshot of the 
|
ciampo
left a comment
ciampo
left a comment
There was a problem hiding this comment.
This is looking good, code-wise! We just need to add a CHANGELOG entry
|
Sure, I have added the entry 👍🏻 |
* Update popover subcomponents * Remove internal usage note from Popover.Slot documentation * Add PopoverSlot component to Popover and update stories * Enhance PopoverSlot component with TypeScript props and update documentation * Refactor PopoverSlot component props * Remove comment * add PopoverSlot as named export * Add changelog entry * Add fullstop * Update documentation section * Update changelog documentation * Update letter casing * Update packages/components/CHANGELOG.md * Update packages/components/CHANGELOG.md --------- Co-authored-by: Rishit30G <[email protected]> Co-authored-by: ciampo <[email protected]> Co-authored-by: mirka <[email protected]>
5 participants
What?
Closes #69615
Why?
This PR solves the issue of the subcomponents of the Popover component not exposing their TypeScript type
How?
Just like the Menu, types for the subcomponents of the Popover are also exposed and no longer require
@ts-expect-errorTesting Instructions
N/A
Screenshots or screencast
N/A