Fix: Ensure consistent margin application for blocks with dynamic block appender#69595
Open
Sourav61 wants to merge 3 commits intoWordPress:trunkfrom
Open
Fix: Ensure consistent margin application for blocks with dynamic block appender#69595Sourav61 wants to merge 3 commits intoWordPress:trunkfrom
Sourav61 wants to merge 3 commits intoWordPress:trunkfrom
Conversation
…ck appender Ensured consistent margin application for blocks with dynamic block appender
…ck appender Ensured consistent margin application for blocks with dynamic block appender
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Revert the unwanted changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensured consistent margin application for blocks when block list appender appears
What?
Closes #61846
Fixes an issue where the .block-list-appender dynamically modifies the block structure, causing inconsistent margin application for blocks inside .is-layout-constrained containers. This ensures that margins are correctly applied even when the block appender is added or removed dynamically.
Why?
Previously, when a block (e.g., Cover block) was inside a Group block with .is-layout-constrained, the following CSS rules were applied:
However, when selecting the Group block in the editor, the .block-list-appender gets appended to the group, making it the new :last-child, which removes the intended margin adjustments from the actual content block, causing a layout shift.
How?
Testing Instructions