Make region navigation more robust #69502
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokesman
added
the
[Focus] Accessibility (a11y)
|
Size Change: +158 B (+0.01%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c44f369. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13753512879
|
Contributor
|
This might actually fix an age old bug I knew about, not sure if I reported it, but you had to tab after the page loaded before region navigation worked. I knew the region navigation exposed it's own DOM element but never thought about the fact that hooking this into the document might be better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Enables region navigation shortcuts to work either when focus is lost or unset—the page just loaded.
Why?
Currently, region navigation may be unexpectedly disabled. The prime example is probably right when the page has loaded the shortcut should work.
How?
useNavigateRegionswith aisGlobaloption that when set totruemakes its keyboard event listeners be attached to the document instead of the element.Testing Instructions for Keyboard
Screenshots or screencast