Skip to content

Cover Block: Show settings inspector controls in the Site Editor #69178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
youknowriad merged 3 commits into from
Nov 8, 2025
Merged

Cover Block: Show settings inspector controls in the Site Editor #69178

youknowriad merged 3 commits into from
Nov 8, 2025

Conversation

@pranvinit
Copy link
Contributor

@pranvinit pranvinit commented Feb 13, 2025 •
edited
Loading

What?

  1. The Cover block was not showing the Settings inspector controls in the Site Editor.

Why?

  1. Because the url attribute was undefined for featured image (fetched contextually in the post) when editing a template.

How?

  1. Extend the condition to show the Settings inspector controls if the user is editing a template.

Testing Instructions

  1. Edit a template (e.g., a Single Post template) in the Site Editor.
  2. Add a Cover block.
  3. Switch the image source to "Use Featured Image" → The Fixed Background option is now available.

Resolves: #69179

Screenshots or screencast

Screen.Recording.2025-02-13.at.2.10.39.PM.mov

@github-actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: pranvinit <[email protected]>
Co-authored-by: youknowriad <[email protected]>
Co-authored-by: tyxla <[email protected]>
Co-authored-by: annezazu <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: renatho <[email protected]>
Co-authored-by: scruffian <[email protected]>
Co-authored-by: mmtr <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Feb 13, 2025
@github-actions
Copy link

github-actions bot commented Feb 13, 2025

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @pranvinit! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Block] Cover Affects the Cover Block - used to display content laid over a background image labels Feb 14, 2025
This was referenced Feb 21, 2025
Closed
Closed
youknowriad
youknowriad reviewed Nov 8, 2025
View reviewed changes
packages/block-library/src/cover/edit/inspector-controls.js Outdated
<>
<InspectorControls>
{ !! url && (
{ ( !! url || ( useFeaturedImage && isSiteEditor ) ) && (
Copy link
Contributor

@youknowriad youknowriad Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need isSiteEditor ?

Copy link
Contributor

@youknowriad youknowriad Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a small commit to remove this from the condition, I think we need the fix to apply to all editors.

@youknowriad youknowriad force-pushed the fix/cover-block-inspector-controls branch from fa703e1 to 3648d98 Compare November 8, 2025 17:37
@youknowriad youknowriad force-pushed the fix/cover-block-inspector-controls branch from 3648d98 to 155b55f Compare November 8, 2025 17:39
tyxla
tyxla reviewed Nov 8, 2025
View reviewed changes
packages/block-library/src/cover/edit/index.js Outdated
},
[ featuredImage, useFeaturedImage ]
);

Copy link
Member

@tyxla tyxla Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ditch that too

Suggested change

tyxla
tyxla approved these changes Nov 8, 2025
View reviewed changes
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this one @pranvinit 🙌

@annezazu
Copy link
Contributor

annezazu commented Nov 8, 2025

This looks great. Thanks for working on this.

@youknowriad youknowriad enabled auto-merge (squash) November 8, 2025 17:42
@youknowriad youknowriad merged commit 3a368cc into WordPress:trunk Nov 8, 2025
35 of 36 checks passed
@github-actions github-actions bot added this to the Gutenberg 22.1 milestone Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowriad youknowriad youknowriad left review comments

@tyxla tyxla tyxla approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees

No one assigned

Labels

[Block] Cover Affects the Cover Block - used to display content laid over a background image First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

Gutenberg 22.1

Development

Successfully merging this pull request may close these issues.

Featured Image on Covers does not have controls to fix image

5 participants

@pranvinit @annezazu @youknowriad @tyxla @t-hamano