Refactor font variant components to use useId for checkbox IDs#69050
Merged
Refactor font variant components to use useId for checkbox IDs#69050
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
torounit
added
[Type] Bug
Mamaduka
approved these changes
Feb 5, 2025
Contributor
|
Thanks for the PR! The whole code looks good. @Mamaduka In this PR, do you know whether |
|
Size Change: -16 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
Member
|
The |
Kallyan01
pushed a commit
to Kallyan01/gutenberg
that referenced
this pull request
Feb 24, 2025
…ress#69050) Co-authored-by: torounit <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: chiilog <[email protected]>
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…ress#69050) Co-authored-by: torounit <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: chiilog <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #68934
Why?
id contains font variants, but they are translated And because kebabCase is applied to the string, the translated string is lost, resulting in an invalid id in cases such as Japanese.
This problem can be solved by changing the id to be generated with useId.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast