Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format Library: Text-color popover width to fit sidebar #68881

Conversation

shimotmk
Copy link
Contributor

What?

Format-library: Text-color popover width to fit sidebar
Make text-color popover width consistent with sidebar.

The code used for reference is as follows.

width: ( $swatch-size * 6 ) + ( $swatch-gap * 5 ) + ( $panelPadding * 2 );

Testing Instructions

  1. Open a post or page.
  2. Insert a paragraph block.
  3. Set Highlight text or background color
  4. You can see that the width matches the sidebar.

Screenshots or screencast

Sidebar

sidebar
You can see six color circles lined up.

Before After
before after

@shimotmk shimotmk requested a review from ellatrix as a code owner January 25, 2025 08:00
Copy link

github-actions bot commented Jan 25, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shimotmk <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Package] Format library /packages/format-library [Feature] Colors Color management labels Jan 27, 2025
@Mamaduka Mamaduka changed the title Format-library: Text-color popover width to fit sidebar Format Library: Text-color popover width to fit sidebar Feb 27, 2025
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @shimotmk!

This is a nice improvement ✅

@Mamaduka Mamaduka added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Feb 27, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Feb 27, 2025
@Mamaduka Mamaduka merged commit 50d457e into WordPress:trunk Feb 27, 2025
63 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.4 milestone Feb 27, 2025
@shimotmk
Copy link
Contributor Author

@Mamaduka
Thanks for the review 👍

@shimotmk shimotmk deleted the fix/format-library__inline-color-popover-width branch February 27, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Colors Color management [Package] Format library /packages/format-library [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants