Skip to content

Comments

Refactor Media Update Progress component#68773

Open
pranvinit wants to merge 2 commits intoWordPress:trunkfrom
pranvinit:refactor/block-media-update-progress-to-function
Open

Refactor Media Update Progress component#68773
pranvinit wants to merge 2 commits intoWordPress:trunkfrom
pranvinit:refactor/block-media-update-progress-to-function

Conversation

@pranvinit
Copy link
Contributor

What?

Migrate the MediaUpdateProgress React component from a React Class to a Functional Component.

Why?

React introduced Hooks in version 16.8 and recommends defining components as functions instead of classes.

How?

Following this document

Testing Instructions

  1. Open a post or page in the editor.
  2. Insert an Image block.
  3. Upload a new image.
  4. Observe the upload progress spinner and ensure it behaves as expected (including success/failure states).

@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: pranvinit <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @pranvinit! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jan 20, 2025
@t-hamano t-hamano added [Type] Code Quality Issues or PRs that relate to code quality [Package] Block editor /packages/block-editor labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Block editor /packages/block-editor [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants