Skip to content

Update the WPCS-related composer dependencies #68470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
anton-vlasenko wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

Update the WPCS-related composer dependencies #68470

anton-vlasenko wants to merge 4 commits into from

Conversation

@anton-vlasenko
Copy link
Contributor

@anton-vlasenko anton-vlasenko commented Jan 2, 2025 •
edited
Loading

What?

This PR updates the WPCS-related composer dependencies to ensure alignment between the Gutenberg and WordPress Core projects.

Why?

It is essential for both codebases to use the same versions of composer packages. This helps streamline the synchronization process and maintain consistency between the codebases.

How?

  • Update Gutenberg to use the same WPCS and related packages as WordPress Core;
  • Update GBCS to match the composer dependency versions used by WPCS;
  • Fix the fatal error in AbstractSniffUnitTest caused by differing method signatures.

Testing Instructions

  1. Review the changes and confirm that all CI jobs pass successfully.
  2. Navigate to the test/php/gutenberg-coding-standards directory.
  3. Run the PHPUnit tests with the following command: 
    composer run-tests
  4. Verify that all unit tests pass without errors.

@github-actions
Copy link

github-actions bot commented Jan 2, 2025

Flaky tests detected in b46a702.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12590241734
📝 Reported issues:

@anton-vlasenko anton-vlasenko marked this pull request as ready for review January 3, 2025 21:17
@github-actions
Copy link

github-actions bot commented Jan 3, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: anton-vlasenko <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@anton-vlasenko anton-vlasenko added the [Type] Build Tooling Issues or PRs related to build tooling label Jan 3, 2025
@anton-vlasenko anton-vlasenko self-assigned this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ironprogrammer ironprogrammer Awaiting requested review from ironprogrammer

@azaozz azaozz Awaiting requested review from azaozz

At least 1 approving review is required to merge this pull request.

Assignees

@anton-vlasenko anton-vlasenko

Labels

[Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anton-vlasenko