Menu: auto-generate README #68249
Menu: auto-generate README #68249
Conversation
ciampo
force-pushed
the
feat/menu-generate-readme
branch
2 times, most recently
from
93215f7 to
323f875
Compare
|
|
||
| const meta: Meta< typeof Menu > = { | ||
| id: 'components-experimental-menu', | ||
| id: 'components-menu', |
There was a problem hiding this comment.
This change was necessary because the generated README links to ?path=/docs/components-menu--docs. I've updated storybook/manager-head.html to add a redirect from the old experimental URL.
| * It can optionally contain one instance of the `Menu.ItemLabel` component | ||
| * and one instance of the `Menu.ItemHelpText` component. | ||
| */ | ||
| Item: Object.assign( Item, { |
There was a problem hiding this comment.
With the previous subcomponent named export scheme (ie. MenuItem being assigned to the Item property of the Menu object), the README generator could not pick up the JSDoc correctly,
I managed to fix it by changing the internal naming convention of all subcomponent by removing the Menu prefix: for example, MenuItem got renamed to Item. A lot of the code changes in this file are related to this refactor and were applied as a single commit. You can review the rest of the changes commit by commit to remove the noise.
| states and behaviors: | ||
| - The `portal` and `preventBodyScroll` props are set to `true`. They can | ||
| still be manually set to `false`. | ||
| - When the dialog is open, element tree outside it will be inert. |
There was a problem hiding this comment.
@mirka here's another instance of the problem you were mentioning with list being merged when rendered to HTML ( #68209 (comment) )
ciampo
added
[Type] Developer Documentation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
force-pushed
the
feat/menu-generate-readme
branch
from
323f875 to
364338a
Compare
|
Flaky tests detected in c5d0b26. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12692406417
|
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
Looks good to me 👍
Needs a rebase and rerun to get the newest improvements.
ciampo
force-pushed
the
feat/menu-generate-readme
branch
from
364338a to
510391e
Compare
|
@tyxla rebased and re-generated README. Could you give a final round of review? |
ciampo
force-pushed
the
feat/menu-generate-readme
branch
from
510391e to
c5d0b26
Compare
Co-authored-by: ciampo <[email protected]> Co-authored-by: mirka <[email protected]> Co-authored-by: tyxla <[email protected]>
What?
Convert the Menu README to an auto-generated one.
Supplementary information that was in the existing README is moved to other appropriate locations (JSDocs, new "Best Practices" Storybook page).
Why?
To decrease maintenance cost and consolidate the canonical docs for our audience.
Testing Instructions
Menu.Itemfor example, and see that the JSDoc includes the subcomponent description.npm run docs:componentsto regenerate READMEs.