Try unifying all the media blocks placeholder under a unique component#6820
Merged
youknowriad merged 1 commit intomasterfrom May 22, 2018
Merged
Try unifying all the media blocks placeholder under a unique component#6820youknowriad merged 1 commit intomasterfrom
youknowriad merged 1 commit intomasterfrom
Conversation
youknowriad
added
[Feature] Blocks
youknowriad
force-pushed
the
try/unify-media-placeholder
branch
from
195f0b9 to
d1b5d7f
Compare
youknowriad
force-pushed
the
try/unify-media-placeholder
branch
from
d1b5d7f to
cb1d09e
Compare
Member
|
🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
MediaPlaceholdercomponent used in all the media blocks to unify their UI. #5456This brings dropzones to audio/video blocks. At the moment the
imagecover-imageandgalleryblocks do not show the "URL" input because if we do so we need to rething the "editing" flow of these blocks. (How to you update the URL? Should we change the edit button in the toolbar to trigger the placeholder even if the media is there (like audio/video)?).So this refactors to use the same component while keeping the same features/flow.
Testing instructions