RangeControl: animate thumb and track only when using marks #67836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
approved these changes
Dec 11, 2024
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
Thanks for the follow-up :)
Contributor
Author
|
Thank you all for all the reviews! I'm not going to add a CHANGELOG entry since this PR basically stacks with #67611 |
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
…s#67836) Co-authored-by: ciampo <[email protected]> Co-authored-by: jameskoster <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: mirka <[email protected]> Co-authored-by: tyxla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Related to https://github.com/WordPress/gutenberg/pull/67611/files#r1880356463
Tweaks the animation applied to the thumb and track elements of
RangeControl, so that the animations only apply when the component is showing "marks"Why?
The animation can introduce a subtle delay that can make the experience of dragging the thumb feel slow and unresponsive.
This PR tries to achieve a good compromise by keeping the animation enabled when the component shows marks, since the experience of dragging the thumb is "stepped" and the animation doesn't really introduce a delay.
How?
CSS changes
Testing Instructions
RangeControlthat doesn't show marks — the thumb and the slider should update instantly following the cursor (ie. no animation)marksto theRangeControl— the thumb and track should animate, like they already do ontrunkThe difference is subtle. Artificially slowing down the transition duration could help debug the changes.