Fix re-renders caused by getEntityRecordsPermissions after #67667#67770
Merged
Fix re-renders caused by getEntityRecordsPermissions after #67667#67770
getEntityRecordsPermissions after #67667#67770Conversation
manzoorwanijk
added
[Type] Performance
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
approved these changes
Dec 10, 2024
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
Thanks for the fix, @manzoorwanijk!
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
…s#67667 (WordPress#67770) * Update getEntityRecordsPermissions signature to allow string ids * Fix regression caused in WordPress#67667 Co-authored-by: manzoorwanijk <[email protected]> Co-authored-by: Mamaduka <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Address the regression mentioned in #67667 (comment)
Why?
Passing an array of string of ids when not needed caused a slight performance issue due to re-renders.
How?
By updating the signature of
getEntityRecordsPermissionsto allow array of stringsTesting Instructions
Testing Instructions for Keyboard
Screenshots or screencast