Size Change: +6.5 kB (+0.33%)

Total Size: 1.95 MB

_{compressed-size-action}

@ellatrix I might need your help with this one. I have aligned the comment board with the respective block. How do I get the sidebar to scroll with the editor now?

Could you try adding a scroll event listener? Or maybe try to use useFloating, which is used by the Popover component as well. The sidebar does not have to scroll, as long as the positions are updated as the canvas is scrolled it should look ok. You'll probably also have to find a way to reconcile comments that appear closely together, maybe we should have a look at Google Docs.

Could you try adding a scroll event listener? Or maybe try to use useFloating, which is used by the Popover component as well.

Thank you @ellatrix , ill check these.

The sidebar does not have to scroll, as long as the positions are updated as the canvas is scrolled it should look ok.

That's the intent.

You'll probably also have to find a way to reconcile comments that appear closely together, maybe we should have a look at Google Docs.

Yes, I have noticed it too and its in my list.

This is how it works now.

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: akasunil <[email protected]>
Co-authored-by: ellatrix <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Hi @ellatrix Could your review here.

Sorry, @akasunil, my main focus is on WP 6.8 release. I’ll try to review this after beta 1, but can’t promise anything before that.

Closing this in favor of new work in #71393

@akasunil Thanks for your work here, which was helpful in working on #71856 which takes a slightly simpler approach by leveraging existing components. Could you help by reviewing that PR to see if we missed anything you are working on here?

If I missed something, please feel free to re-open this PR!