Skip to content

Conversation

@Soean
Copy link
Member

@Soean Soean commented Nov 19, 2024

What?

The function block_core_query_disable_enhanced_pagination() returns the parameter $parsed_block array unmodified. So the return type should be array.

@Soean Soean added the [Type] Developer Documentation Documentation for developers label Nov 19, 2024
@Soean Soean requested a review from ajitbohra as a code owner November 19, 2024 18:45
@github-actions
Copy link

github-actions bot commented Nov 19, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Soean <[email protected]>
Co-authored-by: SantosGuillamot <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@SantosGuillamot SantosGuillamot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and it aligns with other examples in Gutenberg codebase:

@Soean Soean merged commit b4c614f into trunk Nov 22, 2024
68 checks passed
@Soean Soean deleted the query_block/docs branch November 22, 2024 12:15
@github-actions github-actions bot added this to the Gutenberg 19.8 milestone Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants