Try: React 19 <link /> for components#66781
Draft
tyxla wants to merge 22 commits into
Draft
Conversation
tyxla
added
[Package] Components
tyxla
changed the title
<link /> for components
Merged
tyxla
force-pushed
the
try/react-19-beta
branch
from
6a9ada3 to
0ae8c13
Compare
tyxla
force-pushed
the
try/react-19-beta
branch
from
31f99c3 to
da65652
Compare
Mamaduka
force-pushed
the
try/react-19-beta
branch
from
da65652 to
23bba7d
Compare
jsnajdr
force-pushed
the
try/react-19-beta
branch
7 times, most recently
from
bd9eb7f to
3707c06
Compare
jsnajdr
force-pushed
the
try/react-19-beta
branch
7 times, most recently
from
d8a018f to
c217d55
Compare
jsnajdr
force-pushed
the
try/react-19-beta
branch
2 times, most recently
from
f31d2be to
e56d0ce
Compare
jsnajdr
force-pushed
the
try/react-19-beta
branch
from
e56d0ce to
b460b5c
Compare
jsnajdr
force-pushed
the
try/react-19-beta
branch
3 times, most recently
from
062d497 to
84956a8
Compare
jsnajdr
force-pushed
the
try/react-19-beta
branch
4 times, most recently
from
7cdb141 to
7f00ada
Compare
jsnajdr
force-pushed
the
try/react-19-beta
branch
from
7f00ada to
5e5273b
Compare
tyxla
force-pushed
the
try/react-19-beta
branch
3 times, most recently
from
ccdcd5f to
17631bb
Compare
jsnajdr
force-pushed
the
try/react-19-beta
branch
from
17631bb to
a785792
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
As we experiment with React 19, this PR attempts to use
<link />for component styles.For more info, see:
Why?
Currently
@wordpress/componentstyles are a monolithic stylesheet. This approach will allow us to have separate CSS files per component, and to load each of the stylesheets actually when the component is to be rendered.How?
For the experiment, we're refactoring
ButtonGroup's stylesheet from SCSS to CSS. In production, we'd either have CSS modules or have a pre-processing step from SASS to separate CSS files.We're then loading the stylesheet by using
<link />directly in theButtonGroupcomponent.Testing Instructions
Buttonsblock and a couple of buttons in it.Buttonblocks.Testing Instructions for Keyboard
Same
Screenshots or screencast