Fix extraneous scrollbar in device previews#66494
Merged
Merged
Conversation
stokesman
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -20 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
2 tasks
|
Flaky tests detected in 3fce8eb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11528084507
|
t-hamano
approved these changes
Oct 28, 2024
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
LGTM! I have tested extensively and have not found any regressions or visual issues caused by removing overflow-x: hidden.
| Before | After |
|---|---|
 |
 |
Contributor
Author
|
Thanks for testing and reviewing Aki! |
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 29, 2024
Co-authored-by: stokesman <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: colorful-tones <[email protected]> Co-authored-by: dhruvang21 <[email protected]>
github-actions
Bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 88c51c7 |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: stokesman <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: colorful-tones <[email protected]> Co-authored-by: dhruvang21 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
A style revision to fix #66156
Why?
We don’t need a third scrolling area.
How?
Removes
overflow-x: hidden;fromIframe’s__containerelement. This prevents a BFC being formed becauseoverflow-yimplicitly becomesauto. That was causing the element to contain the vertical margins that are added to the iframe in device previews. Those margins plus the100%height of the child seems to be the what creates the overflow.More notes
Changing the
overflow-x: hiddentooverflow: hiddenalso seems to work but also seems unnecessary. Theoverflow-x: hiddenrule originated in #61424 and perhaps was necessary then yet now it seems to have no purpose.Testing Instructions
General tip: make sure your OS is set to always show scrollbars as it makes these types of issues easier to spot.
Device Previews and zoom out
No regression of #65977
1- Run storybook locally npm run storybook:dev
2- Open the playground box story
3- Notice that the height of the canvas is set to 500px, there's no extra border for the iframe and that the width of the canvas is 100%
Screenshots or screencast
fixed-device-preview-extra-scroll-area.mp4