Skip to content

Update README.md #66059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
djcowan wants to merge 1 commit into from
Closed

Update README.md #66059

djcowan wants to merge 1 commit into from

Conversation

@djcowan
Copy link
Contributor

@djcowan djcowan commented Oct 11, 2024

added link text and closing </a> anchor HTML element tag to HTML example line: 83

What?

adding closing open HTML tag

Why?

To assist new users who might be inexperienced with code syntax by limiting unexpected code errors when copy/pasting from examples provided

How?

ensuring example is a valid HTML code fragment

before:

<div data-wp-interactive="myblock" data-wp-router-region="main-list">
  <ul>
     <li><a href="/post-1">Post 1</a></li>
     <li><a href="/post-2">Post 2</a></li>
     <li><a href="/post-3">Post 3</a></li>
  </ul>
  <a data-wp-on--click="actions.navigate" href="/page/2">
</div>

after:

<div data-wp-interactive="myblock" data-wp-router-region="main-list">
  <ul>
     <li><a href="/post-1">Post 1</a></li>
     <li><a href="/post-2">Post 2</a></li>
     <li><a href="/post-3">Post 3</a></li>
  </ul>
  <a data-wp-on--click="actions.navigate" href="/page/2">Page 2</a>
</div>

@djcowan
Update README.md
205fbd1 
added link text and closing `</a>` anchor HTML element tag to HTML example line: 83
@github-actions
Copy link

github-actions bot commented Oct 11, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: djcowan <[email protected]>
Co-authored-by: skorasaurus <[email protected]>
Co-authored-by: shail-mehta <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@skorasaurus skorasaurus added the [Type] Developer Documentation Documentation for developers label Nov 12, 2024
skorasaurus
skorasaurus approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@skorasaurus skorasaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me; thanks.

@shail-mehta
Copy link
Member

shail-mehta commented Jan 29, 2025 •
edited
Loading

@djcowan Thanks for the PR.

Could you please rebase this PR? (Because some tests are failing)

@djcowan
Copy link
Contributor Author

djcowan commented Jan 31, 2025

Yes, I can rebase but unsure when I will have the opportunity to do so.

@shail-mehta shail-mehta mentioned this pull request Feb 12, 2025
Merged
@t-hamano
Copy link
Contributor

t-hamano commented Feb 13, 2025

Closing this PR as #69166 has been merged.

@t-hamano t-hamano closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@skorasaurus skorasaurus skorasaurus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

[Type] Developer Documentation Documentation for developers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@djcowan @shail-mehta @t-hamano @skorasaurus