Always preview style variations using desktop device type#66023
Merged
Always preview style variations using desktop device type#66023
Conversation
draganescu
changed the title
draganescu
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +19 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Oct 11, 2024
Member
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
Defaulting to desktop seems like a good approach to me.
Here's how things look before:
And me trying to break it with this PR:
Kapture.2024-10-11.at.14.48.21.mp4
getdave
reviewed
Oct 11, 2024
packages/edit-site/src/components/global-styles/screen-style-variations.js
Outdated
Show resolved
Hide resolved
getdave
approved these changes
Oct 11, 2024
Contributor
getdave
left a comment
getdave
left a comment
There was a problem hiding this comment.
Tested and works as described plus it seem logical.
|
Flaky tests detected in f941d61. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11290723518
|
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 11, 2024
* always preview style variations using desktop device type * Improve comment --------- Co-authored-by: draganescu <[email protected]> Co-authored-by: getdave <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: richtabor <[email protected]> Co-authored-by: juanfra <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 1ae3f5f |
ciampo
pushed a commit
that referenced
this pull request
Oct 14, 2024
* always preview style variations using desktop device type * Improve comment --------- Co-authored-by: draganescu <[email protected]> Co-authored-by: getdave <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: richtabor <[email protected]> Co-authored-by: juanfra <[email protected]>
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…66023) * always preview style variations using desktop device type * Improve comment --------- Co-authored-by: draganescu <[email protected]> Co-authored-by: getdave <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: richtabor <[email protected]> Co-authored-by: juanfra <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #65991
Fixes the style variations preview when a device type is set, whcih currently zooms out the preview of small viewports.
Why?
The device viewports are already small, scaling them out results in an unuseable UI.
How?
Reset the device type when browse styles is invoked and the variation route is loaded. Always use the desktop device type to preview style variations.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
reset-device-type-browse-styles.mp4