Remove additional Typeset screen and surface typesets in the typography panel #65579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -226 B (-0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
jffng
force-pushed
the
revert/typesets-panel
branch
from
71b42d3 to
6d9a472
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jffng
added
[Type] Regression
vcanales
approved these changes
Sep 23, 2024
Member
vcanales
left a comment
vcanales
left a comment
There was a problem hiding this comment.
Looks good, works as advertised.
Member
|
As a side note, I think this UI might be lacking some contextual information about where—as in, to which elements—the Font Families within a Typeset are being applied. cc. @richtabor |
jffng
force-pushed
the
revert/typesets-panel
branch
from
6d9a472 to
cc9970f
Compare
jffng
added
the
Backport to WP 6.9 Beta/RC
jffng
force-pushed
the
revert/typesets-panel
branch
from
cc9970f to
b1eaa4f
Compare
|
Flaky tests detected in b1eaa4f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11075476932
|
Contributor
Author
|
Noting that the test failure is related to a flaky test case reported here: #63665. |
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Sep 27, 2024
…hy panel (#65579) * Remove additional Typeset screen and surface typesets in the typography panel. * Merge custom and theme font families in getFontFamilyFromSetting.
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: d26e784 |
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
…hy panel (WordPress#65579) * Remove additional Typeset screen and surface typesets in the typography panel. * Merge custom and theme font families in getFontFamilyFromSetting.
huubl
added a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
…typography panel (WordPress#65579)" This reverts commit 831b8da.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR surfaces the typography variations ("typesets") directly in the Typography panel, removing the need for a separate Typeset screen right now.
Why?
See #65575
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast