Icons: Adds bell and bell-unread icons #65324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierarce
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
|
The |
|
Size Change: +945 B (+0.05%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
Contributor
|
I like the design :) If you run the markup through https://svgomg.net/ I think there's potential for some further optimisation. We tend to avoid separate paths within the same icon, but the justification seems valid here. I'd welcome more feedback on that from @WordPress/gutenberg-design. |
Contributor
Author
Oops, you are right. I just optimized the icons a bit more. |
jameskoster
approved these changes
Sep 16, 2024
jameskoster
requested changes
Sep 16, 2024
Contributor
jameskoster
left a comment
jameskoster
left a comment
There was a problem hiding this comment.
Ah, I noticed there's no changelog entry, lets add that before merging :)
javierarce
added
the
props-bot
github-actions
bot
removed
the
props-bot
Contributor
Author
@jameskoster: added |
jameskoster
approved these changes
Sep 17, 2024
Contributor
|
Thank you! :) |
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds two new icons:
bellandbell-unread.Why?
These are common icons helpful to indicate notifications and pending notifications.
Testing Instructions
npm run storybook:devhttp://localhost:50240/?path=/story/icons-icon--librarybellandbell-unreadicons.Screenshots
References
Proposals in the Figma library: