Fix: Button: Replace remaining 40px default size violation [Edit Site 3] #65309
Conversation
| <Button | ||
| // TODO: Switch to `true` (40px size) if possible | ||
| __next40pxDefaultSize={ false } | ||
| __next40pxDefaultSize |
There was a problem hiding this comment.
This can be seen when you visit, site-editor --> check for patterns and the pattern title.
Note: It has a link variant, so there is an override style present, so before and after is same.
| Before | After |
|---|---|
 |
 |
| <Button | ||
| // TODO: Switch to `true` (40px size) if possible | ||
| __next40pxDefaultSize={ false } | ||
| __next40pxDefaultSize |
There was a problem hiding this comment.
This can be seen, when you open the save panel. It has style for screen-reader-text, hence need to remove that style to see the visual change.
| Before | After |
|---|---|
 |
 |
| <Button | ||
| // TODO: Switch to `true` (40px size) if possible | ||
| __next40pxDefaultSize={ false } | ||
| __next40pxDefaultSize |
There was a problem hiding this comment.
This can be seen when you visit, site-editor --> and check for icon button in sidebar panel.
| Before | After |
|---|---|
 |
 |
| <Button | ||
| // TODO: Switch to `true` (40px size) if possible | ||
| __next40pxDefaultSize={ false } | ||
| __next40pxDefaultSize |
There was a problem hiding this comment.
This can be seen when you add a custom data view and click on add new.
| Before | After |
|---|---|
 |
 |
| <Button | ||
| // TODO: Switch to `true` (40px size) if possible | ||
| __next40pxDefaultSize={ false } | ||
| __next40pxDefaultSize |
There was a problem hiding this comment.
This can be seen when you add a custom data view and click on add new.
| Before | After |
|---|---|
|
|
| <Button | ||
| // TODO: Switch to `true` (40px size) if possible | ||
| __next40pxDefaultSize={ false } | ||
| __next40pxDefaultSize |
There was a problem hiding this comment.
This can be seen when you visit and check for go back button on the top left corner in site editor mode.
Note: It has fixed height, so changing this does not change before and after images.
| Before | After |
|---|---|
 |
 |
| <Button | ||
| // TODO: Switch to `true` (40px size) if possible | ||
| __next40pxDefaultSize={ false } | ||
| __next40pxDefaultSize |
There was a problem hiding this comment.
This can be seen when you visit and check for site title in site editor mode.
Note: It has link variant, hence 40px size does not affect the button.
| Before | After |
|---|---|
 |
 |
| <Button | ||
| // TODO: Switch to `true` (40px size) if possible | ||
| __next40pxDefaultSize={ false } | ||
| __next40pxDefaultSize |
There was a problem hiding this comment.
This can be seen when you visit and check for search icon on the site editor mode.
| Before | After |
|---|---|
 |
 |
| <Button | ||
| // TODO: Switch to `true` (40px size) if possible | ||
| __next40pxDefaultSize={ false } | ||
| __next40pxDefaultSize |
There was a problem hiding this comment.
This can be seen when you visit and check for go to back button on top left corver in site editor mode for mobile mode.
Note: It has fixed height, so changing this does not change before and after images.
| Before | After |
|---|---|
 |
 |
| <Button | ||
| // TODO: Switch to `true` (40px size) if possible | ||
| __next40pxDefaultSize={ false } | ||
| __next40pxDefaultSize |
There was a problem hiding this comment.
This can be seen when you visit and check for search icon on the site editor mode on mobile.
| Before | After |
|---|---|
 |
 |
| <Button | ||
| // TODO: Switch to `true` (40px size) if possible | ||
| __next40pxDefaultSize={ false } | ||
| __next40pxDefaultSize |
There was a problem hiding this comment.
This can be seen when you visit and check for site title in site editor mode for mobile.
Note: It has link variant, hence 40px size does not affect the button.
| Before | After |
|---|---|
 |
 |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
It appears like there are some consistently failing e2e tests. Could they be related? I'd be surprised if they are, but let's try rebasing the branch, maybe that will resolve the failures. |
mirka
force-pushed
the
fix/issue-65018-7
branch
from
dfed4f4 to
b9ab536
Compare
|
Something is cursed about this branch, we just cannot get it to pass CI checks 😭 The failures are varied and don't seem to be related to the changes in this PR. I'm trying a clean rebase as a last resort. |
|
Yay, it worked! 🎉 |
mirka
added
the
Backport to WP 6.9 Beta/RC
noisysocks
added
Backported to WP Core
… 3] (#65309) * Fix patterns link button title to use 40px default size * Fix open save panel button default size to 40px * Fix editor sidebar buttons to use 40px defualt size * Fix data views create new views buttons to use 40px default size * Fix site hub buttons to use 40px default button size --------- Co-authored-by: hbhalodia <[email protected]> Co-authored-by: mirka <[email protected]> Co-authored-by: tyxla <[email protected]>
4 participants
Part of - #65018
What?
page-patterns,save-panel,sidebar-buttons,sidebar-daatviews, andsite-hub.Why?
How?
__next40pxDefaultSize={ false }to__next40pxDefaultSizeon component.Testing Instructions