Pagination Block: Fix inconsistent margins between editor and frontend#64874
Merged
tjcafferkey merged 9 commits intotrunkfrom Sep 4, 2024
Merged
Pagination Block: Fix inconsistent margins between editor and frontend#64874tjcafferkey merged 9 commits intotrunkfrom
tjcafferkey merged 9 commits intotrunkfrom
Conversation
…margins consistent
|
Size Change: +901 B (+0.05%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 0ae2d03. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10599719310
|
Contributor
Author
|
There remains a specificity issue whereby if you want to use "core/query-pagination-previous": {
"spacing": {
"margin": {
"bottom": "0"
}
}
}These are overridden by the |
tjcafferkey
added
[Block] Query Pagination
This was referenced Aug 29, 2024
Contributor
Is there any reason you would want to use margin in a flex layout? Pinning @tellthemachines @aaronrobertshaw for visibility |
Contributor
Author
|
@t-hamano you're right, but in this case they wanted to be reset back to |
tjcafferkey
requested review from
ajitbohra,
fabiankaegy,
juanmaguitar and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
|
The margin issues can occur with any block in a flex layout, so this issue might be worth discussing more extensively in #43248. How about removing the addition of margin/padding support from this PR for now? |
Contributor
Author
t-hamano
approved these changes
Sep 4, 2024
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
LGTM!
I've tested multiple themes, browser sizes, and pagination variations and they all seem to work as expected. The layout is more consistent with the removal of redundant margins.
Twenty Twenty-Four
Desktop
| Before | After |
|---|---|
 |
 |
Mobile
| Before | After |
|---|---|
 |
 |
Twenty Twenty-One
Desktop
| Before | After |
|---|---|
 |
 |
Mobile
| Before | After |
|---|---|
 |
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes woocommerce/woocommerce#42204
Fixes #51299
What?
Why?
Fix the inconsistent margins between the editor and the front-end.
How?
By removing offending CSS rules.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast