Skip to content

Bump AGP to 8.5.1 #64044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
geriux merged 3 commits into from
Aug 5, 2024
Merged

Bump AGP to 8.5.1 #64044

geriux merged 3 commits into from
Aug 5, 2024

Conversation

@wzieba
Copy link
Contributor

@wzieba wzieba commented Jul 29, 2024 •
edited
Loading

What?

Bump Android Gradle Plugin used by react-native-bridge/android to version 8.5.1

Why?

How?

Bump version in settings.gradle

Testing Instructions

Perform both tests in release variant.

Comment

AGP in version 8.4.0 brings changes to how libraries are obfuscated. I don't suspect any issues here as it's a standalone SDK (not a library module) and enableProguardInReleaseBuilds value is set to false. Anyway, it's good to double-check this.

Testing Instructions for Keyboard

Screenshots or screencast

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jul 29, 2024
@github-actions
Copy link

github-actions bot commented Jul 29, 2024

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @wzieba! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@wzieba wzieba force-pushed the bump_agp_to_8_5_1 branch from 952906d to 2b03954 Compare July 30, 2024 12:52
@geriux geriux added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Jul 30, 2024
@wzieba wzieba force-pushed the bump_agp_to_8_5_1 branch from 2b03954 to 7c96736 Compare July 31, 2024 09:01
@wzieba wzieba marked this pull request as ready for review July 31, 2024 09:35
@github-actions
Copy link

github-actions bot commented Jul 31, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: wzieba <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@geriux geriux added the Mobile App - Automation Label used to initiate Mobile App PR Automation label Jul 31, 2024
@wpmobilebot wpmobilebot mentioned this pull request Jul 31, 2024
Merged
@geriux geriux added the [Type] Code Quality Issues or PRs that relate to code quality label Jul 31, 2024
@geriux geriux self-requested a review August 5, 2024 08:44
@geriux geriux removed the Mobile App - Automation Label used to initiate Mobile App PR Automation label Aug 5, 2024
geriux
geriux approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@geriux geriux merged commit ee2fb29 into WordPress:trunk Aug 5, 2024
@github-actions github-actions bot added this to the Gutenberg 19.0 milestone Aug 5, 2024
This was referenced Aug 6, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@geriux geriux geriux approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Milestone

Gutenberg 19.0

Development

Successfully merging this pull request may close these issues.

2 participants

@wzieba @geriux