Conversation
|
Thanks for the revision. Would this string suffer from the issues described in #5361 ? |
Yes. I brought this up in #6124 (comment). In practice, I dare say this particular string would be less affected than others, mainly since the variable to be interpolated is a proper noun referring to more or less the same kind of thing — a Web service, typically with a English-sounding name —, meaning it's more likely that gender will be consistent and more likely that inflexion is not needed. But I stress the word likely: one can probably make it work in most Romance languages and modern Germanic, but some other languages really do need the inflexion, and the rendered string will be wrong. A Finnish speaker described this kind of string as "Nokia language" (as Nokia, itself Finnish, couldn't properly solve i18n), since the ideal translation would be something like:
Note the inflected form of YouTube. But, because of the inability of translation systems to mark inflexion needs in things like embed names, the cop-out in Finnish goes something like:
or, a tad more gracefully, by constructing the unit “Youtube -service”
Others are expected to be affected too: Estonian, Hungarian, Turkish, etc. |
|
My comment above is a bit academic and not very actionable, so here's the takeaway:
|
|
@ajitbohra, could you rebase this branch? The purpose of this PR was to fix how the string was provided, not what the string should be, so I don't want to block this. :) |
|
@ajitbohra, thanks for the rebase. One last request: could you add a gutenberg/editor/components/block-list/block.js Lines 413 to 414 in d8d7be5 In this case, it would be: // translators: %s: Name of service (e.g. VideoPress, YouTube) |
|
@mcsf translators note added |
|
Thanks! Merged. |
Description
Fix translation string to use sprintf
How has this been tested?
npm run test:unitScreenshots
N/A
Types of changes
Translation fix
Checklist: