Skip to content

Heading: Add border support #63539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aaronrobertshaw merged 1 commit into from
Jul 16, 2024
Merged

Heading: Add border support #63539

aaronrobertshaw merged 1 commit into from
Jul 16, 2024

Conversation

@aaronrobertshaw
Copy link
Contributor

@aaronrobertshaw aaronrobertshaw commented Jul 15, 2024 •
edited
Loading

Part of: #43241

What?

Adopts border support for heading blocks.

Why?

  • Offers greater design flexibility
  • Improves consistency in design tooling with other blocks
  • Block already has padding and background color support. This adds another missing piece.

How?

  • Adopt all border supports.

Testing Instructions

  1. In the site editor, add a Heading block to a page
  2. Style all Heading blocks via Global Styles and confirm the editor and frontend display correctly
  3. Override the global styles on a block instance and confirm they display appropriately in the editor and frontend

Screenshots or screencast

Screen.Recording.2024-07-15.at.12.29.39.PM.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Block] Heading Affects the Headings Block CSS Styling Related to editor and front end styles, CSS-specific issues. labels Jul 15, 2024
@aaronrobertshaw aaronrobertshaw self-assigned this Jul 15, 2024
@github-actions
Copy link

github-actions bot commented Jul 15, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: aaronrobertshaw <[email protected]>
Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@aaronrobertshaw aaronrobertshaw added the [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi label Jul 15, 2024
@aaronrobertshaw aaronrobertshaw mentioned this pull request Jul 15, 2024
Open
@aaronrobertshaw aaronrobertshaw merged commit 71ee76e into trunk Jul 16, 2024
@aaronrobertshaw aaronrobertshaw deleted the add/heading-border-support branch July 16, 2024 00:22
@github-actions github-actions bot added this to the Gutenberg 18.9 milestone Jul 16, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jul 18, 2024
@aaronrobertshaw @carolinan @carstingaxion
Heading: Add border support (WordPress#63539)
64638a8 
Co-authored-by: aaronrobertshaw <[email protected]>
Co-authored-by: carolinan <[email protected]>
@fabiankaegy fabiankaegy mentioned this pull request Oct 1, 2024
Closed
97 tasks
@ndiego ndiego mentioned this pull request Oct 26, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carolinan carolinan carolinan approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@aaronrobertshaw aaronrobertshaw

Labels

[Block] Heading Affects the Headings Block CSS Styling Related to editor and front end styles, CSS-specific issues. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

Gutenberg 18.9

Development

Successfully merging this pull request may close these issues.

3 participants

@aaronrobertshaw @carolinan