-
Notifications
You must be signed in to change notification settings - Fork 4.6k
[Mobile] - Update components imports #61109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile] - Update components imports #61109
Conversation
|
Size Change: 0 B Total Size: 1.74 MB ℹ️ View Unchanged
|
…lar-dependencies-components
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
twstokes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🚀
…#61102) * Components - Move mobile global styles context to the block editor package * Components - Remove moved files * Components - Move mobile AudioPlayer to Block Editor components * Update moved components * Components - Update exports for native Block Editor and Component packages * Update imports in block files * Update imports for format library and color settings * Update imports in block editor and editor components * [Mobile] - Update components imports (#61109) * Components - AutoComplete - Fix components imports * Components - ColorIndicator - Fix components imports * Components - ColorPicker - Fix components imports * Components - CustomGradient - Fix components imports * Components - DashIcon - Fix components imports * Components - Draggable - Fix components imports * Components - DropdownMenu - Fix components imports * Components - FocalPointPicker - Fix components imports * Components - FontSizePicker - Fix components imports * Components - AutoCompletion - Fix components imports * Components - BottomSheet - Fix components imports * Components - ColorSettings - Fix components imports * Components - FocalPointSettingsPanel - Fix components imports * Components - Gradient - Fix components imports * Components - Image - Fix components imports * Components - LinkPicker - Fix components imports * Components - LinkSettings - Fix components imports * Components - MediaEdit - Fix components imports * Components - Picker - Fix components imports * Components - Panel - Fix components imports * Components - QueryControls - Fix components imports * Components - SearchControl - Fix components imports * Components - Tooltip - Fix components imports Co-authored-by: geriux <[email protected]> Co-authored-by: twstokes <[email protected]> * Mobile - Update changelog --------- Co-authored-by: geriux <[email protected]> Co-authored-by: twstokes <[email protected]>
Related PRs:
Part of #61102
Addresses #52692
What?
This PR is a follow-up of #61102 to remove the pending circular dependencies within the
componentspackage.Why?
The initial prompt started at #27751 so this is a continuation of the ongoing effort to remove/reduce circular dependencies.
How?
Updating the imports to use internal dependencies from the
componentspackage.As mentioned in the parent PR, before these changes, we had 80 warnings of require cycles, with these two PRs we will have only 45 remaining, none of those are from the components package anymore so we can focus on the rest in future iterations.
Testing Instructions
CI checks should pass.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A