Core Block Reference: Add ancestor status and refactor generation logic #59390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
t-hamano
requested review from
ajitbohra,
fabiankaegy,
juanmaguitar,
ndiego,
nerrad,
ntwb and
ryanwelcher
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
fabiankaegy
approved these changes
Feb 27, 2024
Member
fabiankaegy
left a comment
fabiankaegy
left a comment
There was a problem hiding this comment.
This is a great enhancement and the code looks good to me :)
gziolo
approved these changes
Feb 27, 2024
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
Nice one! There is also allowedBlocks introduced in WP 6.5 that will have to be explicitly listed.
Contributor
Author
|
@fabiankaegy @gziolo Thanks for the review!
I see, I would like to respond with follow-up PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #58603
What?
This PR makes two changes to the core block reference page:
ancestorfieldWhy?
I think the
ancestorfield is important information for developers, just like the already existingparentfield.Also, the current logic produces Attributes/Supports fields with no values, which seems unnecessary:
How?
The previous logic seemed unstable because newline characters were added dynamically.
This PR first defines an array to display the block information list. After that, if there is any information that can be displayed, push it into the array. Finally, it outputs the elements of that array separated by newlines.
This should also make it easier to add fields in the future.
Testing Instructions
Compare the readme files.