After Enter transform, skip other onEnter actions like splitting #59064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Type] Bug
jsnajdr
requested review from
dcalhoun,
ellatrix and
fluiddot
as code owners
jsnajdr
commented
Feb 15, 2024
Member
Author
There was a problem hiding this comment.
This leads to the onCustomEnter handler not being called, but that should be OK. If I understand correctly, it's used to handle things like list splitting (#43949).
Member
There was a problem hiding this comment.
The #43949 test plan succeeds for me on an iPhone 15 Pro simulator.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +4 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6eeb7d9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7931141170
|
jsnajdr
force-pushed
the
fix/enter-transform
branch
from
6890e78 to
b64c7fc
Compare
dcalhoun
approved these changes
Feb 15, 2024
Member
dcalhoun
left a comment
dcalhoun
left a comment
There was a problem hiding this comment.
It doesn't appear the use case of typing --- is supported on mobile currently, but the changes do not appear to introduce regressions. 🚀
Member
There was a problem hiding this comment.
The #43949 test plan succeeds for me on an iPhone 15 Pro simulator.
tyxla
approved these changes
Feb 15, 2024
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
Great find, and works like a charm 👍
jsnajdr
force-pushed
the
fix/enter-transform
branch
from
b64c7fc to
6eeb7d9
Compare
Member
Author
|
There are permanent e2e test failures when testing the Navigation block. It's like if this branch was running the e2e tests with WordPress 6.4, then they would fail as described in https://github.com/WordPress/gutenberg/pull/58389/files#r1492414765. Locally, when I run them against WP 6.5, the tests all succeed. And there is no good reason for the Navigation tests to fail, there is no |
youknowriad
added
the
Backport to WP 6.9 Beta/RC
getdave
pushed a commit
that referenced
this pull request
Feb 20, 2024
) Co-authored-by: jsnajdr <[email protected]> Co-authored-by: ellatrix <[email protected]> Co-authored-by: dcalhoun <[email protected]> Co-authored-by: tyxla <[email protected]>
Contributor
|
I just cherry-picked this PR to the cherry-pick-beta-2 branch to get it included in the next release: 54b7e41 |
getdave
removed
the
Backport to WP 6.9 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Feb 20, 2024
) Co-authored-by: jsnajdr <[email protected]> Co-authored-by: ellatrix <[email protected]> Co-authored-by: dcalhoun <[email protected]> Co-authored-by: tyxla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I type
---and then hit Enter, it triggers a block transform that creates the Separator block. This should be the end of it, but currently theuseEnter/onEnterhandlers continue handling the Enter keypress and try to do things like block splitting. But they shouldn't do this. It leads to a bogusREPLACE_BLOCKSaction that tries to do a split, but it does nothing because the blocks to be replaced were already replaced by a previousREPLACE_BLOCKSaction (which created the Separator).How to test:
Put a logpoint on the
REPLACE_BLOCKSaction. Before this patch, there are two of them dispatched on Enter. After this patch, only one is dispatched.