[Pattern Overrides] Fix duplication of inner blocks#57538
Merged
Conversation
kevin940726
added
[Type] Experimental
|
Size Change: +17 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Jan 5, 2024
Contributor
aaronrobertshaw
left a comment
aaronrobertshaw
left a comment
There was a problem hiding this comment.
LGTM 👍
✅ Could replicate original issue
✅ Applying the changes here resolves the problem
P.S. I updated the PR description to mention turning on the pattern overrides experiment for anyone else following along to these changes.
49 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fix #57502.
The
innerBlocksare reusing the sameclientIds, which causes the issue.Why?
It's a UI bug. See #57502.
How?
Always clone the blocks to generate new
clientIds.Testing Instructions
Enable the "Pattern Overrides" Gutenberg experiment:
Copied from the original issue:
Screenshots or screencast
N/A