Editor: Use the same PostTemplatePanel between post and site editors#56817
Merged
youknowriad merged 8 commits intotrunkfrom Dec 7, 2023
Merged
Editor: Use the same PostTemplatePanel between post and site editors#56817youknowriad merged 8 commits intotrunkfrom
youknowriad merged 8 commits intotrunkfrom
Conversation
youknowriad
requested review from
andrewserong,
jameskoster,
jasmussen,
ntsekouras and
ramonjd
youknowriad
commented
Dec 6, 2023
|
Size Change: +67 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 86d808e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7125538260
|
ellatrix
reviewed
Dec 6, 2023
ellatrix
reviewed
Dec 6, 2023
packages/editor/src/components/post-template/reset-default-template.js
Outdated
Show resolved
Hide resolved
ellatrix
approved these changes
Dec 6, 2023
Member
ellatrix
left a comment
ellatrix
left a comment
There was a problem hiding this comment.
Nice! Love the consistency between editors!
youknowriad
force-pushed
the
update/post-template-panel
branch
from
8c92482 to
ecbbbec
Compare
Contributor
|
Nice, this is working well for me excerpt for one detail; You can create a new template for pages where the template resolves automatically. E.g. if you edit the Posts page when Blog home exists, or if you edit the static homepage when Front page exists. The newly template even appears to get assigned to the page, but the frontend uses the correct template according to the hierarchy resulting in a mismatch. Should we disable new template creation in those scenarios? |
Contributor
Author
|
@jameskoster Good catch, I think it should be fixed now. |
Contributor
Author
|
I noticed thanks to the e2e test that this seems to break "custom templates" in classic themes. |
Contributor
Author
|
Ok Thanks to e2e tests, I had to:
|
Contributor
Author
|
I still think we need to a bit more tests here. I'm almost certain that this breaks for contributors in the post editor but I don't have time today, I need to disconnect. |
youknowriad
force-pushed
the
update/post-template-panel
branch
from
7d311e5 to
86c413d
Compare
Member
|
Working as described for me 🎉
Do you mean the contributor role? If so, I tried creating pending posts as a contributor (who doesn't have access to template actions or the site editor), and then logged in with admin to swap templates and publish and couldn't see any errors. |
andrewserong
reviewed
Dec 7, 2023
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
Very cool! So nice being able to toggle the template preview within the post editor 🎉
Also, updating the featured image via the Featured Image block in template preview mode updates the image in the Featured image panel and vise versa 👍
2023-12-07.11.59.05.mp4
I haven't run into any major issue so far in testing. One tiny thing I noticed is that in the template preview mode we still output the padding-bottom: 40vh rule, which means that the post appears to extend a bit further vertically than I expected. Is that intentional?
Another tiny thing is the padding / styling on this popover in Classic themes (looks like not quite enough padding on this PR?):
| This PR | Trunk |
|---|---|
 |
 |
Contributor
Author
|
Good catch @andrewserong both of these issues should be fixed. |
Contributor
|
I submitted #57112, which might be an issue related to this PR. |
This was referenced Dec 28, 2023
4 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #52632
Builds on top of previous PR that align template modes between post and site editors.
What?
This PR unifies the "template" panel/selectors on the document settings sidebar between the post and site editors. This means
Testing Instructions
Test the different flows related to the template panel in both post and site editors for classic and block themes.