Fix DropdownMenu svg icon size #56450
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
apeatling
added
[Feature] UI Components
mirka
added
[Package] Components
Contributor
|
Left a comment in the original issue in case we could spot the deeper reason why the SVG icon is not receiving a size. |
mirka
added
the
[Status] Needs More Info
Contributor
|
Closing as per the conversation in #56448 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #56448
Why?
While working on Sensei LMS, we realized that there's a new issue with the
DropdownMenucomponent. Here is the issue: Automattic/sensei#7308It seems it started happening after this change: https://github.com/WordPress/gutenberg/pull/43574/files#r1240745574.
I'm not sure if there were additional styles setting the
svgsize at some point, but if there were, they are no longer present.How?
This PR adds back that properties with the
svgsize.Testing Instructions
DropdownMenucomponent with thecontrolsprop. You can use the example from https://developer.wordpress.org/block-editor/reference-guides/components/dropdown-menu/#usage-2.Screenshots or screencast