Font Library: remove insecure properties#56230
Merged
Conversation
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/experimental/fonts/font-library/class-wp-font-family.php ❔ phpunit/class-wp-theme-json-test.php |
jffng
added
[Type] Enhancement
jffng
commented
Nov 16, 2023
| 'typography' => array( | ||
| 'fontFamilies' => array( $this->data ), | ||
| 'fontFamilies' => array( | ||
| 'custom' => array( |
Contributor
Author
There was a problem hiding this comment.
The custom key is necessary to accommodate the input expected by remove_insecure_properties.
matiasbenedetto
approved these changes
Nov 17, 2023
Contributor
matiasbenedetto
left a comment
matiasbenedetto
left a comment
There was a problem hiding this comment.
This makes sense to me. Thanks for the enhancement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Leverages the
remove_insecure_propertiesmethod of WP_Theme_JSON class to further validate the CSS saved to the database and output to the client.The PR also adds a unit test to verify the use case.
Why?
Currently it is possible to include and output non-valid CSS in the font family definition of global styles.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast