Skip to content

Fix DayButton dot position and expand Button area#55502

Merged
mirka merged 6 commits intoWordPress:trunkfrom
kurudrive:fix-day-button-dot
Dec 19, 2023
Merged

Fix DayButton dot position and expand Button area#55502
mirka merged 6 commits intoWordPress:trunkfrom
kurudrive:fix-day-button-dot

Conversation

@kurudrive
Copy link
Copy Markdown
Contributor

@kurudrive kurudrive commented Oct 20, 2023

What?

Adjustment of the dot position on DayButton and expansion of the button area.

Why?

In the DatePicker, the dot indicating the publish date is too close to the background circle, making it look unappealing.

issue : #51966

スクリーンショット 2023-10-20 16 05 15

How?

I shifted the dot's position 2px upward and slightly expanded the button area.

Testing Instructions

  1. Create new post and publish
  2. Open the DatePicker by clicking on the publish date in the edit screen.

Testing Instructions for Keyboard

Screenshots or screencast

Before

スクリーンショット 2023-10-20 16 05 15 スクリーンショット 2023-10-20 16 05 36

After

スクリーンショット 2023-10-20 16 03 17 スクリーンショット 2023-10-20 16 03 45

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Oct 20, 2023
@github-actions
Copy link
Copy Markdown

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @kurudrive! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@kurudrive kurudrive changed the title Fix DatButton dot position and expand Button area Fix DayButton dot position and expand Button area Oct 20, 2023
@t-hamano t-hamano added [Package] Components /packages/components [Type] Enhancement A suggestion for improvement. labels Oct 20, 2023
@kurudrive kurudrive marked this pull request as ready for review October 20, 2023 07:30
@kurudrive kurudrive requested a review from ajitbohra as a code owner October 20, 2023 07:30
@apeatling apeatling added the Needs Design Feedback Needs general design feedback. label Dec 1, 2023
@mirka mirka requested a review from a team December 15, 2023 12:19
Copy link
Copy Markdown
Member

@ajitbohra ajitbohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise looks good needs design feedback

Copy link
Copy Markdown
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I think it's a nice improvement for visual clarity 👍

If there are no objections from @WordPress/gutenberg-design, I'm comfortable merging because it's a small change and easy to tweak if there are better ideas.

@jasmussen
Copy link
Copy Markdown
Contributor

Looks like a good little improvement.

@mirka mirka enabled auto-merge (squash) December 19, 2023 13:04
@mirka mirka merged commit e47ba1b into WordPress:trunk Dec 19, 2023
@github-actions github-actions bot added this to the Gutenberg 17.4 milestone Dec 19, 2023
artemiomorales pushed a commit that referenced this pull request Jan 4, 2024
* Fix DatButton dot position and expand Button area

* add change log

* Move changelog

---------

Co-authored-by: Lena Morita <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Needs Design Feedback Needs general design feedback. [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants