Use lodash includes in the navigable menu.#5528
Merged
jorgefilipecosta merged 3 commits intomasterfrom Mar 9, 2018
Merged
Conversation
aduth
approved these changes
Mar 9, 2018
Member
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
While we're here, maybe update these as well?
gutenberg/editor/store/selectors.js
Line 1101 in c2710e3
gutenberg/editor/store/selectors.js
Line 1135 in c2710e3
From #4497 (cc @noisysocks)
Contributor
Author
|
@aduth done (please double check, not really my area of expertise) |
Member
|
Looks good. Thanks. |
3 tasks
jorgefilipecosta
force-pushed
the
fix/navigable-menu-arrow-navigation-ie11
branch
from
3f76567 to
21c956f
Compare
Member
|
I added a commit that does the same refactor in a very recent change in a selector that happened after this PR was created. Thank you for the PR, array includes is something I will try to keep an eye. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to fix a bug where the
NavigableMenucomponent used the nativeincludeswhich is not supported in IE11, causing the arrows navigation to break.Fixes #5527