[RNMobile] Cover block: Refactor overlay color attribute update logic to match the web version #54831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the logic of the native version closer to the web version.
fluiddot
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 1.62 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 2b95374. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6314402850
|
fluiddot
deleted the
rnmobile/update/cover-block-overlay-color-attribute
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Following recent changes (#54054), this PR refactors the logic to update the overlay color attribute to match a similar behavior as the web version.
Why?
Enhances the workaround provided in #54825.
How?
TBD
Testing Instructions
TBD
Testing Instructions for Keyboard
N/A
Screenshots or screencast
TBD