Default template lookup should use slug, not the full permalink, in the site editor #54599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejolley
added
the
[Type] Bug
|
Size Change: -2 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
Mamaduka
added
the
[Feature] Site Editor
draganescu
approved these changes
Sep 19, 2023
Contributor
draganescu
left a comment
draganescu
left a comment
There was a problem hiding this comment.
Didn't test but the change makes sense since the called function clearly expects a slug not the whole link.
ntsekouras
approved these changes
Sep 19, 2023
Contributor
ntsekouras
left a comment
ntsekouras
left a comment
There was a problem hiding this comment.
Thanks for fixing this @mikejolley !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
#51477 introduced template swap UX, but in doing so it broke the default template lookup. Details and screenshots of the issue can be found in the issue here but the heart of the issue was that requests to the API were including the permalink instead of the slug, so for example, it tried to lookup the slug
page-http://xxxxxinstead ofpage-slug.Why?
This restores the correct template for pages and avoids them defaulting to "pages" template, even if custom templates are in place.
How?
This replaces the
linkproperty with the correctslugproperty.Testing Instructions
https://store.local/wp-json/wp/v2/templates/lookup?slug=page-https%3A%2F%2Fstore.local%2Fcart%2F&_locale=useror similar. After this patch you'll see the correct lookup address ofhttps://store.local/wp-json/wp/v2/templates/lookup?slug=page-cart%2F&_locale=useror similar. Note theslugparameter is fixed.