Interactivity API: Add missing tests for body, init and on directives#52952
Merged
Interactivity API: Add missing tests for body, init and on directives#52952
body, init and on directives#52952Conversation
|
Size Change: -16 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
8 tasks
DAreRodz
force-pushed
the
add/interactivity-api-missing-tests
branch
from
a3a4abb to
557ff31
Compare
DAreRodz
added
[Feature] Interactivity API
DAreRodz
requested review from
Mamaduka,
ajitbohra,
kevin940726,
luisherranz,
nerrad and
ntwb
as code owners
Contributor
Author
|
This PR is ready for review. I decided not to include tests for cc: @luisherranz |
luisherranz
approved these changes
Aug 9, 2023
Member
luisherranz
left a comment
luisherranz
left a comment
There was a problem hiding this comment.
Amazing work as always, David 🙂
packages/e2e-tests/plugins/interactive-blocks/directive-init/view.js
Outdated
Show resolved
Hide resolved
packages/e2e-tests/plugins/interactive-blocks/directive-init/view.js
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Includes tests for directives that still need to get them.
data-wp-bodydata-wp-initdata-wp-on--[event]Additionally, certain features could remain uncovered by current tests. It would be interesting to identify them and add the required tests in this (or a subsequent) PR.
Why?
To have all directives adequately tested.
How?
Following the same approach for the rest of the tests:
/e2e-test/plugins/interactive-blocks/for each directive, containing different test cases./test/e2e/specs/interactivity/for each directive.Testing Instructions
Added tests should pass.