Skip to content

Improve inline documentation #5238#5239

Merged
aduth merged 2 commits intoWordPress:masterfrom
Shelob9:patch-4
Feb 28, 2018
Merged

Improve inline documentation #5238#5239
aduth merged 2 commits intoWordPress:masterfrom
Shelob9:patch-4

Conversation

@Shelob9
Copy link
Copy Markdown
Contributor

@Shelob9 Shelob9 commented Feb 24, 2018

Description

Conforms phpdoc blocks to WordPress coding standards by ommitted @access public and fixing one typo for @return

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code has proper inline documentation.

Copy link
Copy Markdown
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still several other @access public in this very file. Were those intentionally skipped, or overlooked?

@Shelob9
Copy link
Copy Markdown
Contributor Author

Shelob9 commented Feb 27, 2018

@aduth I got the others via 91561fd

Copy link
Copy Markdown
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@aduth aduth merged commit ec79a84 into WordPress:master Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants