Closed
Conversation
Prevents conflicts with connected components competing for shared store
In nested context, block selection changes from reusable block to the inner block being edited, but we want to keep the UI shown
1 task
Member
Author
|
Superseded by #5228 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In-Progress: Generally complete and working, but needs a close audit of revisions to reusable blocks APIs, as it is possible / likely that redundant data is being tracked.
This pull request seeks to resolves issues with saving a nested block as reusable.
This includes a number of revisions to...
innerBlocksin reusable-specific block factory methods, store effects, and reducersBlockListBlocktoBlockEdit, as the latter is the component used in rendering fromcore/block'seditblockstoeditor, asBlockEditrequires access to theBlockListcomponentqueryhigher-order component, as this can otherwise conflict with other store-dependant wrappers.Future Tasks:
We arguably ought to consolidate the block and reusable block object types, as there's a fair bit of redundancy between the two, evidenced by copying of behaviors from the original nested blocks implementation.
Testing instructions:
Verify there are no regressions in the behavior of reusable blocks.
Ensure that you can save a Columns block, including content, as a reusable block.
Ensure unit tests pass: