Skip to content

Conversation

@thealexandrelara
Copy link
Contributor

What?

This PR fixes the Create a Block Tutorial link located on packages/blocks/README.md

Why?

Currently, if a user clicks on the Create a Block Tutorial link, they get redirected to a 404 page:
image

How?

In this PR, I'm replacing the old link that was pointing to docs/how-to-guides/block-tutorial/README.md with the new link that points to the correct file location at /docs/getting-started/create-block/README.md

Testing Instructions

  1. Visite the Blocks package README.md file;
  2. On the registerBlockType section, click on Create a Block Tutorial link
  3. Check the page is redirected to the Create a Block Tutorial page and not to a 404 page

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @thealexandrelara! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Apr 3, 2023
@skorasaurus skorasaurus added the [Type] Developer Documentation Documentation for developers label Apr 3, 2023
Copy link
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thealexandrelara
Copy link
Contributor Author

@thealexandrelara PR looking good. One note on the failing test.

https://github.com/WordPress/gutenberg/actions/runs/4599968627/jobs/8126010841?pr=49562

Can you try to fix and commit this locally?

Hey @alexstine thank you for pointing that out! I just pushed a fix!

Copy link
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@alexstine alexstine merged commit ef9ed1a into WordPress:trunk Apr 5, 2023
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

Congratulations on your first merged pull request, @thealexandrelara! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 15.6 milestone Apr 5, 2023
@thealexandrelara thealexandrelara deleted the docs/fix-create-a-block-tutorial-link branch April 5, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants