Blocks: Ensure string return value from render_callback#4879
Merged
Conversation
aduth
added
the
[Feature] Block API
jorgefilipecosta
approved these changes
Feb 6, 2018
Member
jorgefilipecosta
left a comment
jorgefilipecosta
left a comment
There was a problem hiding this comment.
Our CI tests were failing but I restarted the job and now they are passing. The changes look good to me 👍
Member
|
The |
Member
Author
|
Oof, good catch @johnbillion, I wrongly expected |
Member
|
Yeah it's an annoying one, that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #4716 (comment)
This pull request seeks to update and verify the behavior of
WP_Block_Typeto ensure a string return value from itsrenderfunction, as documented in inline code docs.Testing instructions:
Verify PHPUnit tests pass:
cc @tfrommen